Bump migration timestamps after 4.89.2 cherry-picks (4.90 RC)#49850
Merged
georgekarrv merged 1 commit intoJul 23, 2026
Merged
Conversation
The 4.89.2 patch RC (rc-patch-fleet-v4.89.2) received two cherry-picks that carry DB migrations: - #48664 20260702164518_DedupeWindowsProgramTitlesFromUpgradeCode - #49515 20260717152653_FixInstallStatusPrecedence This makes 20260717152653 the newest (max) applied migration in 4.89.2. But on main/4.90 there are 11 migrations with timestamps *earlier* than 20260717152653 that are not present in 4.89.2: 20260704213830 DropWindowsMDMCommandResultsCommandUUIDForeignKey 20260706174522 ReparseWindowsHostCertificates 20260707071142 AddWindowsMDMConfigProfilesPriorContent 20260707140752 AddDDMAssetsTable 20260708153912 FixEmbeddedBundleTitleNames 20260708185958 CreateApplePSSOTables 20260708190008 AddPSSODeviceRegistrationTokenFleetVar 20260708192536 AddNanoQueueNextCommandIndex 20260713115453 CreateHostMDMAppleDeviceNames 20260715144547 CustomHostVitals 20260715214831 MultipleCustomPackagesPerTitle A database upgraded through 4.89.2 records 20260717152653 as its max applied migration, so on upgrade to 4.90 those 11 would be out-of-order. Bump them so they sort after the current newest migration (20260721160351), preserving their relative order. Schema DDL is unchanged (schema.sql differs only in the migration_status_tables version list). To be cherry-picked into rc-minor-fleet-v4.90.0.
cdcme
approved these changes
Jul 23, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.90.0 #49850 +/- ##
=========================================================
Coverage ? 67.87%
=========================================================
Files ? 3890
Lines ? 248272
Branches ? 12967
=========================================================
Hits ? 168521
Misses ? 64543
Partials ? 15208
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: N/A — release-engineering fix for migration forward-compatibility
Summary
Cherry-pick of #49849 into
rc-minor-fleet-v4.90.0.The 4.89.2 patch RC received two cherry-picks carrying DB migrations (#48664
DedupeWindowsProgramTitlesFromUpgradeCode, #49515FixInstallStatusPrecedence), making20260717152653the newest applied migration in 4.89.2. This 4.90 RC contains 11 migrations with timestamps earlier than20260717152653that are not in 4.89.2, so a database upgraded through 4.89.2 (max applied =20260717152653) would encounter them out-of-order when upgrading to 4.90:These are bumped to
20260723181401–20260723181411(after20260717152653), preserving relative order and matching the timestamps used onmainin #49849 so the two lines stay consistent.schema.sqlwas regenerated against this RC's migration set; DDL is unchanged (only themigration_status_tablesversion list differs). This RC does not include20260721090128/20260721160351(they are not part of 4.90), so those are intentionally absent from the regenerated schema.Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing
Migrations replay cleanly in the new order via
make dump-test-schema; regeneratedschema.sqldiffers only in themigration_status_tablesINSERT (table definitions byte-identical).Database migrations
COLLATE utf8mb4_unicode_ci).No migration logic was changed — only timestamps/filenames were bumped to fix ordering.