Skip to content

Handle both binary and text mode #5397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle both binary and text mode #5397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7dc1c
fix(cli): prevent UnicodeDecodeError when relaying child stdout
jistiak Jun 24, 2025
e1e657a
Handle both binary and text mode
jistiak Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions sdk/python/packages/flet-cli/src/flet_cli/commands/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,13 @@ def on_any_event(self, event):

def print_output(self, p):
while True:
line = p.stdout.readline()
if not line:
raw = p.stdout.readline()
if not raw:
break
line = line.rstrip("\r\n")

line = raw.decode("utf-8", errors="replace") if isinstance(raw, bytes) else raw
line = line.rstrip("\r\n")

if line.startswith(self.page_url_prefix):
if not self.page_url:
self.page_url = line[len(self.page_url_prefix) + 1 :]
Expand Down