-
Notifications
You must be signed in to change notification settings - Fork 16
uploading hexagonal band diagram calculation example #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Spell Check ReportHexagonalLatticeBands.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
|
Thanks @FilipeFcp ! Just a couple of things:
|
alec-flexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example again @Filipe! A couple things:
-
I think Callable is imported but not used
-
In the second cell, you import numpy a second time
-
the **args argument in the ftField function isn't used - maybe you can drop?
-
When all is edited remember run all cells in order so the cells are ordered
-
Momchil brings up a good point with modes above the light line. It could be interesting to see, but I'm not sure how much time it would take to get good results
tomflexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition to answer a pretty common question! Thanks @FilipeFcp . The notebook is also well organized with a great teaching style.
The header "K-points definition" -> "K-points Definition".
|
Nice. Just one thing, I would word "source decay time and mask the data immediately after the decay" a bit differently since to me this sounds like you remove the data after the source decay. Maybe "source decay time and only use the data after the decay." And it still seems to me that |
|
Thanks @momchil-flex! I was plotting the FT for debugging, and forgot to remove it in the final version |

Hi all,
I’m uploading the example for the hexagonal band diagram calculations.
There is one cell with some theory that was entirely generated by AI. I’m still debating whether we should keep it or remove it to make the example shorter.
@momchil-flex, feel free to take a look if you have time