-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add script to check misc file references #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a validation script to check that notebook files correctly reference misc directory files. The script verifies that referenced files exist and are properly declared in the import file mapping.
- Reformats
import_file_mapping.jsonfor better readability with multi-line entries - Adds new script
check_misc_references.pyto validate misc file references in notebooks - Integrates the validation check into the GitHub Actions lint workflow
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| misc/import_file_mapping.json | Reformatted from single-line to multi-line format and added new notebook-file mappings |
| misc/check_misc_references.py | New Python script that scans notebooks for misc directory references and validates them |
| .github/workflows/lint-notebooks.yml | Added workflow_dispatch trigger and new validation step for misc file references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.