Skip to content

Conversation

@daquinteroflex
Copy link
Collaborator

No description provided.

@daquinteroflex daquinteroflex force-pushed the dario/fix_notebooks_2102 branch from 3666f8e to 21cef77 Compare January 19, 2026 16:11
@daquinteroflex daquinteroflex marked this pull request as ready for review January 19, 2026 16:11
@github-actions
Copy link
Contributor

Spell Check Report

AvalanchePhotodiode.ipynb:

Cell 1, Line 1: 'photodiode'
  > # Avalanche photodiode
Cell 1, Line 3: 'photodiode'
  > This notebook demonstrates the modeling of an on-chip avalanche photodiode (APD). These photodetectors provide internal signal amplification by operating under high reverse bias and are used in many applications where it is necessary to detect very weak optical signals.
Cell 1, Line 13: 'band-to-band'
  > We will define both the optical and charge properties of the materials, including doping, and models for band-to-band tunneling and impact ionization.
Cell 11, Line 12: 'Nunley'
  > optical=td.material_library["Ge"]["Nunley"],
Cell 20, Line 8: 'x-size'
  > # Cross-section simulation (x-size=0), periodic bc OK for mode extraction
Cell 47, Line 3: 'unity-gain'
  > Over the whole bias range, the bright current remains higher than the dark current, and both increase monotonically with reverse bias. Around −2 V we observe the unity-gain operating point, where the onset of impact ionization occurs, consistent with the value reported in the paper.

CreatingGeometryUsingTrimesh.ipynb:

Cell 33, Line 3: 'axisymmetric'
  > Another powerful way to generate complex surfaces is to revolve a 2D polygon around an axis. This is especially handy for axisymmetric components such as lenses, resonators, or tapered fibers where the cross section is easier to sketch in 2D. We can sketch the profile as a list of vertices and let `trimesh` sweep it through 360° to obtain a solid mesh.
Cell 34, Line 7: 'array-like', 'post-rotation'
  > """Return a revolved `trimesh.Trimesh` by sweeping a 2D polygon about the z-axis.
Cell 35, Line 1: 'aspheric-like'
  > # define a simple aspheric-like lens profile in the x-z plane

Checked 7 notebook(s). Found spelling errors in 2 file(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/21144332257

@daquinteroflex
Copy link
Collaborator Author

@tomflexcompute I've manually compared the rerun plots with the develop state, they match well for all notebooks. We will need to merge this for 2.10.2

Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daquinteroflex looks good.

@daquinteroflex daquinteroflex merged commit 2d19206 into develop Jan 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants