-
Notifications
You must be signed in to change notification settings - Fork 16
upload Silicon Hybrid example #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Spell Check ReportSiliconOrganicHybrid.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
alec-flexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome notebook @FilipeFcp ! Excellent organization and flow (I also liked the summary of workflow at the top). Just a few variables that are defined but I don't think are used:
Importing pandas
fwidth
clad_gap
sio2_metal_gap
pad_x, pad_y, pad_z
|
Good catch, thanks @alec-flexcompute ! |
tomflexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition @FilipeFcp . All looks great. Could you get rid of the warning in the tidy3d import by removing the legacy config file?
This is an example that I explored for the optical meeting.
Unfortunately it is pretty hard to compare exactly with paper results, because many parameters are not provided.