Skip to content

Conversation

FilipeFcp
Copy link
Contributor

@FilipeFcp FilipeFcp commented Oct 8, 2025

Hi @momchil-flex. Thanks for reporting this. It is fixed now.

image

Greptile Overview

Updated On: 2025-10-08 15:38:54 UTC

Summary

This pull request fixes a documentation inconsistency in the `GaussianBeam` class within `tidy3d/components/source/field.py`. The change corrects a reference in the class docstring's Notes section where `beam_distance` was incorrectly mentioned instead of the actual parameter name `waist_distance`.

The GaussianBeam class defines a parameter called waist_distance (lines 576-586), but the documentation's Notes section was referencing a non-existent beam_distance parameter. This fix ensures the documentation accurately reflects the actual parameter name, maintaining consistency between the class definition and its documentation. This type of fix is important for user experience as it prevents confusion when developers read the docstring and try to use the parameter.

Important Files Changed

Changed Files
Filename Score Overview
tidy3d/components/source/field.py 5/5 Fixed documentation inconsistency by correcting parameter name reference from beam_distance to waist_distance

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only corrects documentation text
  • Score reflects a simple documentation fix with no functional code changes that could introduce bugs
  • No files require special attention as this is a straightforward text correction

@FilipeFcp FilipeFcp requested a review from momchil-flex October 8, 2025 15:37
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants