Skip to content

Conversation

@marcorudolphflex
Copy link
Contributor

@marcorudolphflex marcorudolphflex commented Jan 27, 2026

PRs from dependabot are currently rejected due to branch name linting. Think we might just disable it?
https://github.com/flexcompute/tidy3d/actions/runs/21400098223/job/61608502300


Note

Exempts Dependabot PRs from branch name Jira key checks to prevent CI failures on automated dependency updates.

  • Adds condition to enforce-jira-key step in tidy3d-python-client-tests.yml to run only for PRs not opened by dependabot[bot]

Written by Cursor Bugbot for commit 7ed594a. This will update automatically on new commits. Configure here.

Greptile Overview

Greptile Summary

Added conditional logic to skip Jira key enforcement for Dependabot PRs. The change adds if: github.actor != 'dependabot[bot]' to the enforce-jira-key step in the branch name linting job, preventing automated dependency update PRs from failing due to missing Jira keys in their branch names.

  • Resolves CI failures for Dependabot PRs that cannot include Jira keys in their automated branch names
  • Aligns with existing exemption pattern (chore, hotfix, daily-chore prefixes already exempt)
  • Follows custom rule 42c6ce6c-d2b4-4972-b7ef-11f53cd63cc3 which recommends exemptions for automated processes like dependabot

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a single-line conditional addition that precisely addresses the stated problem of Dependabot PRs failing branch name validation. The implementation follows GitHub Actions best practices, correctly uses the github.actor context variable, and aligns with the repository's custom rule for exempting automated processes. No logic errors, security concerns, or unintended side effects are present.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/tidy3d-python-client-tests.yml Added conditional to skip Jira key enforcement for dependabot[bot] PRs, resolving CI failures for automated dependency updates

Sequence Diagram

sequenceDiagram
    participant Dependabot
    participant GitHub
    participant Workflow as CI Workflow
    participant JiraCheck as Jira Key Check
    
    Dependabot->>GitHub: Create PR (dependency update)
    GitHub->>Workflow: Trigger tidy3d-python-client-tests
    Workflow->>Workflow: determine-test-scope
    Workflow->>Workflow: lint-branch-name job
    Workflow->>Workflow: extract-branch-name
    Workflow->>JiraCheck: enforce-jira-key step
    
    alt github.actor != 'dependabot[bot]'
        JiraCheck->>JiraCheck: Check branch name for Jira key
        JiraCheck->>JiraCheck: Check PR title for Jira key
        JiraCheck-->>Workflow: Pass/Fail based on Jira key presence
    else github.actor == 'dependabot[bot]'
        Note over JiraCheck: Step skipped (if: condition false)
        JiraCheck-->>Workflow: Step skipped - Pass
    end
    
    Workflow->>GitHub: Report workflow status
Loading

Context used:

  • Rule from dashboard - When implementing branch name validation rules, ensure exemptions are added for automated processes ... (source)

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@marcorudolphflex marcorudolphflex force-pushed the FXC-5132-ignore-jira-branch-lint-for-dependabot branch from 6cd320d to 7ed594a Compare January 27, 2026 16:34
@marcorudolphflex
Copy link
Contributor Author

alternatively, we could also set a fixed prefix to the PR name on an ongoing ticket like "FXC-1234" - what do you prefer?

@github-actions
Copy link
Contributor

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants