chore(tidy3d): FXC-5132-ignore-jira-branch-lint-for-dependabot #3210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs from dependabot are currently rejected due to branch name linting. Think we might just disable it?
https://github.com/flexcompute/tidy3d/actions/runs/21400098223/job/61608502300
Note
Exempts Dependabot PRs from branch name Jira key checks to prevent CI failures on automated dependency updates.
enforce-jira-keystep intidy3d-python-client-tests.ymlto run only for PRs not opened bydependabot[bot]Written by Cursor Bugbot for commit 7ed594a. This will update automatically on new commits. Configure here.
Greptile Overview
Greptile Summary
Added conditional logic to skip Jira key enforcement for Dependabot PRs. The change adds
if: github.actor != 'dependabot[bot]'to theenforce-jira-keystep in the branch name linting job, preventing automated dependency update PRs from failing due to missing Jira keys in their branch names.Confidence Score: 5/5
github.actorcontext variable, and aligns with the repository's custom rule for exempting automated processes. No logic errors, security concerns, or unintended side effects are present.Important Files Changed
dependabot[bot]PRs, resolving CI failures for automated dependency updatesSequence Diagram
sequenceDiagram participant Dependabot participant GitHub participant Workflow as CI Workflow participant JiraCheck as Jira Key Check Dependabot->>GitHub: Create PR (dependency update) GitHub->>Workflow: Trigger tidy3d-python-client-tests Workflow->>Workflow: determine-test-scope Workflow->>Workflow: lint-branch-name job Workflow->>Workflow: extract-branch-name Workflow->>JiraCheck: enforce-jira-key step alt github.actor != 'dependabot[bot]' JiraCheck->>JiraCheck: Check branch name for Jira key JiraCheck->>JiraCheck: Check PR title for Jira key JiraCheck-->>Workflow: Pass/Fail based on Jira key presence else github.actor == 'dependabot[bot]' Note over JiraCheck: Step skipped (if: condition false) JiraCheck-->>Workflow: Step skipped - Pass end Workflow->>GitHub: Report workflow statusContext used:
dashboard- When implementing branch name validation rules, ensure exemptions are added for automated processes ... (source)