Skip to content

Fix Jest tests for React Native #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Jest tests for React Native #20

wants to merge 1 commit into from

Conversation

raviqqe
Copy link

@raviqqe raviqqe commented Jan 13, 2022

Fix for Jest tests with React Native, where navigator.userAgent === undefined.

@raviqqe raviqqe changed the title Fix for React Native Fix Jest tests for React Native Jan 13, 2022
yibe
yibe approved these changes Apr 25, 2022
View reviewed changes
Copy link

@yibe yibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FYI, this is not a Jest-specific issue: navigator.userAgent is undefined in the real React Native environment, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@yibe yibe yibe approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raviqqe @yibe