test: add comma-stripping test#288
Closed
gabrnavarro wants to merge 1 commit intofloatpane:masterfrom
Closed
Conversation
Signed-off-by: gabrnavarro <gabrnavarro@users.noreply.github.com>
andrinoff
changed the title
Member
|
@gabrnavarro, this PR most likely is botted with no declaration of it in the description. Please, do read Contribution Guide We'd be happy to work with you, but when You submit the PR with understanding of the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a test for the comma-stripping behavior in
AddContact(config/cache.go). The fix itself (stripping leading/trailing commas from email addresses before saving contacts) was already present at line 156 viastrings.Trim(strings.TrimSpace(email), ","), but had no test coverage.Why
Fixes #251
When users typed an email address in the compose view and a comma was automatically appended (as a separator), the contact was being saved with the trailing comma (e.g.
friend@example.com,). On the next save the comma-suffixed version would be stored as a separate contact entry.The fix ensures commas are stripped from both ends of the email before saving or deduplicating contacts.
Testing
TestAddContactStripsCommasinconfig/config_test.gocovering trailing comma, leading comma, both commas, no comma, and whitespace+comma cases.go test ./config/... -v -run TestAddContactStripsCommas).viewpackage test failure (TestImageProtocolSupported) is unrelated to this change and was already failing on the base branch.