Skip to content

Added getTimeFormat function so that the time parsing can deal with different time formats #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwindibank wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added getTimeFormat function so that the time parsing can deal with different time formats #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@ module.exports = function (opts) {
const offsetMs = opts.offsetMs || 0

const TIME_FORMAT = 'HH:mm:ss.SSS'
const TIME_FORMAT_SHORT = 'mm:ss.SSS'
const TIME_SEPARATOR = ' --> '

function parseTimes (line) {
return line.split(TIME_SEPARATOR)
.map(timeString => moment(timeString.trim(), TIME_FORMAT))
.map(timeString => moment(timeString.trim(), getTimeFormat(timeString)))
}

function shiftTimeLine (line, offsetMs) {
Expand All @@ -22,6 +23,12 @@ module.exports = function (opts) {
.join(TIME_SEPARATOR)
}

function getTimeFormat (timestring) {
//hours on VTT files are optional
//if the lenth of the timestring is less 9 characters or less, assume it's short, otherwise the standard
return timestring.trim().length <= 9 ? TIME_FORMAT_SHORT : TIME_FORMAT
}

function isTimeLine (line) {
return line.indexOf(TIME_SEPARATOR) > -1
}
Expand Down