Skip to content

asyncAddFiles fixes #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

ilessiivi
Copy link

  • Cleaned up the formatting a bit, removed unused variable
  • Adds an extra filtering between file-added and files-added hooks to unify the behavior between sync and async code

@drzraf
Copy link
Collaborator

drzraf commented Sep 20, 2021

The cleanup part is minor and the change from this.hook => await this.aHook will soon be changed again to await this.hook.
I suggest to discard it so that the functional change can happen in the bigger async-only PR where it makes more sense.
(And the small cleanup about variable can be forgotten for now)
I think it'll be simpler to manager your multiple PR (good job btw) and a more readable git history.

@ilessiivi
Copy link
Author

I'll close this PR, the changes will be in #354.

@ilessiivi ilessiivi closed this Sep 23, 2021
@ilessiivi ilessiivi deleted the asyncAddFilesFixes branch September 23, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants