Brendan/170/cookbook for s3 bucket cache setup #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendaneamon
requested review from
stahnma,
garbas,
nicklewis,
billlevine and
zmitchell
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
0be9455 to
294722e
Compare
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
294722e to
d5a33be
Compare
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
d5a33be to
69c7c24
Compare
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
69c7c24 to
18376ed
Compare
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
18376ed to
cfdcedf
Compare
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
cfdcedf to
b8614bc
Compare
zmitchell
reviewed
Mar 28, 2025
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
28cfae2 to
1f5a695
Compare
Also restructure the menu so that the cookbook section is now called "publish" instead of "infrastructure."
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
1f5a695 to
20fb23a
Compare
|
brendaneamon
force-pushed
the
brendan/170/cookbook-for-S3-bucket-cache-setup
branch
from
fc65fae to
12b6bb3
Compare
@zmitchell, I think I've covered that with the commit I just pushed, but let me know if you think we need more detail. Thanks! |
|
In hindsight the signing key isn't strictly related to the S3 bucket setup, so I think I'll split the signing key part into a separate page. Thanks for writing it up though so I can just copy/paste! |
zmitchell
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170