lua: fix return value documentation for record and code 2#2366
lua: fix return value documentation for record and code 2#2366eschabell merged 1 commit intofluent:masterfrom
Conversation
📝 WalkthroughWalkthroughDocumentation update to Lua filter clarifies that the original record is replaced when callback return codes are 1 or 2, not just code 1 as previously stated. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Benoit Plessis <bplessis@sierrawireless.com>
cf9eebe to
80c6877
Compare
eschabell
left a comment
There was a problem hiding this comment.
@bplessis-swi this is a good catch, thanks for the PR fix!
Lua documentation state that the
recordfield is only used when thecodeis equal to1but it's also used with2when we only change the record content if i am not mistakenSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.