-
Notifications
You must be signed in to change notification settings - Fork 1.4k
out_forward: add warning for zstd as experimental #4896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kenhys
merged 1 commit into
fluent:master
from
daipom:out_forward-add-warning-for-zstd-as-experimental
Apr 10, 2025
Merged
out_forward: add warning for zstd as experimental #4896
kenhys
merged 1 commit into
fluent:master
from
daipom:out_forward-add-warning-for-zstd-as-experimental
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: fluent#4758 Signed-off-by: Daijiro Fukuda <[email protected]>
Watson1978
approved these changes
Apr 10, 2025
kenhys
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for your review! |
This was referenced Jun 27, 2025
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Aug 4, 2025
What is experimental is out_forward. See fluent#4896. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this pull request
Aug 4, 2025
**Which issue(s) this PR fixes**: None. **What this PR does / why we need it**: Fix v1.19.0 CHANGELOG. What is experimental is out_forward. See #4896. **Docs Changes**: Not needed. **Release Note**: Not needed. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
to daipom/fluentd
that referenced
this pull request
Sep 11, 2025
Partially backported from fluent#4896 Signed-off-by: Daijiro Fukuda <[email protected]>
Partially backporting this CI fix seems reasonable. |
daipom
added a commit
that referenced
this pull request
Sep 11, 2025
… (#5092) **Which issue(s) this PR fixes**: * Partially backported from #4896 **What this PR does / why we need it**: Refactor out_forward compress setting tests. **Docs Changes**: Not needed. **Release Note**: CI fixes. Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
When using
compress zstd
forout_forward
, output the following warning log.In #4758, it was agreed that we would refrain from updating the forward protocol v1.5 for the time being and instead output a log message indicating that this feature is experimental.
Docs Changes:
Not needed. (It should be done as #4657)
Release Note:
Not needed. (A note for #4657 would be enough.)