-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update Google Fonts to v7.0.0 with new and removed fonts #10713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google_fonts package to version 7.0.0, introducing a substantial number of new fonts while removing several older ones. The changes include updating the CHANGELOG.md to reflect these additions and removals, modifying the families_supported list in the generator, and updating numerous part_*.g.dart files to include new font definitions (e.g., Doto, Faculty Glyphic, Geist, Google Sans Code, Hind Mysuru, Host Grotesk, Hubot Sans, Huninn, Iansui, Intel One Mono, Kanchenjunga, Kapakana, Karla Tamil Inclined, Karla Tamil Upright, TikTok Sans, Tirra, Triodion, Tuffy, UoqMunThenKhung, Vend Sans, WDXL Lubrifont JP N, WDXL Lubrifont SC, WDXL Lubrifont TC, Winky Rough, Winky Sans, Zalando Sans, Zalando Sans Expanded, Zalando Sans SemiExpanded) and remove others (e.g., IBM Plex Sans Condensed, Open Sans Condensed, Roboto Condensed, Saira Condensed variants). Many existing font hashes and sizes were also updated across the generated Dart files, indicating underlying font file changes.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This is an awesome update, thank you!
LGTM
Added support for numerous new fonts and removed several deprecated or replaced fonts as part of the 7.0.0 update. Updated the font family lists, generated font part files, and the changelog to reflect these changes. This corresponds to directory 11, generated in December 2025.
Changed the fontWeight in generated_font_methods_test.dart from FontWeight.w600 to FontWeight(549) to test behavior with non-standard font weights.
83f2736 to
c59d827
Compare
flutter/packages@d3f860d...9705815 2026-01-07 [email protected] [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 [email protected] [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 [email protected] [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 [email protected] [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 [email protected] [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 [email protected] Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@d3f860d...9705815 2026-01-07 [email protected] [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 [email protected] [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 [email protected] [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 [email protected] [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 [email protected] [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 [email protected] Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ries when a static entry of the same weight and style exists (#10739) #10713 accidentally introduced duplicate variable fonts for 400 weight fonts, an issue only discovered through https://pub.dev/packages/google_fonts/score, because this repo's analysis options exclude generated files. Using 7.0.0 would cause the variable font variant to be used for 400 weight, a non-issue, apart from the typically larger font size. With this PR: - Updated the font generator to exclude variable font entries when a static entry of the same weight and style exists, keeping variable fonts only if no static equivalent is present. - Updated font proto and regenerated Dart parts. - Renamed generated files from .g.dart to .dart for google_fonts_all_parts and all font part files. Updated generator, template, and main library to use the new file extensions, and added some missing public API documentation. - Prepares for future explicit variable font support and improves font selection consistency. Fixes flutter/flutter#180634 Related to flutter/flutter#174575 and flutter/flutter#174567 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
dart generator/generator.dartadds support for numerous new fonts and removed several deprecated or replaced fonts. This corresponds to directory 11, generated in September 2025.