-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[ci] Adjust workflow for dispatching go_router batch release #10733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
|
gemini told me it may be due to the workflow lacking the content write permission where the default github token only has read permission. Adjusted the workflow accordingly |
| - name: Repository Dispatch | ||
| uses: peter-evans/repository-dispatch@5fc4efd1a4797ddb68ffd0714a238564e4cc0e6f | ||
| with: | ||
| token: "${{ secrets.GITHUB_TOKEN }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this workflow by default uses GITHUB_TOKEN so this line is redundant
flutter/packages@d3f860d...9705815 2026-01-07 [email protected] [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 [email protected] [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 [email protected] [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 [email protected] [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 [email protected] [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 [email protected] Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@d3f860d...9705815 2026-01-07 [email protected] [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 [email protected] [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 [email protected] [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 [email protected] [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 [email protected] [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 [email protected] [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 [email protected] Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I think this is what was missing, the current error message without this patch https://github.com/flutter/packages/actions/runs/20761184331
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3