-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add migration guide for https://github.com/flutter/flutter/pull/164034 #11924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The author of the change is OOO, @goderbauer reviewed, hoping I got this right. :) |
Visit the preview URL for this PR (updated for commit 7d974da): https://flutter-docs-prod--pr11924-mixinguide-k0m880qz.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
new 'layoutInfo' getter to implement. | ||
--- | ||
|
||
## Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I remember this sounds all correct. I do wonder, though, if we should re-add a class RenderConstrainedLayoutBuilder
with a default implementation of layoutInfo
to reduce churn and make this not breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh way better, let me look into this today. Thank you @goderbauer!
Description of what this PR is changing or adding, and why:
Adds a migration guide for flutter/flutter#164034, whcih was identified as breaking in beta testing in flutter/flutter#167247
Issues fixed by this PR (if any):
Fixes flutter/flutter#167247
Presubmit checklist