Skip to content

Add migration guide for https://github.com/flutter/flutter/pull/164034 #11924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 22, 2025

Description of what this PR is changing or adding, and why:

Adds a migration guide for flutter/flutter#164034, whcih was identified as breaking in beta testing in flutter/flutter#167247

Issues fixed by this PR (if any):

Fixes flutter/flutter#167247

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@Piinks Piinks requested review from sfshaza2, antfitch, parlough and a team as code owners April 22, 2025 16:52
@Piinks Piinks requested a review from goderbauer April 22, 2025 16:53
@Piinks
Copy link
Contributor Author

Piinks commented Apr 22, 2025

The author of the change is OOO, @goderbauer reviewed, hoping I got this right. :)

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Apr 22, 2025

Visit the preview URL for this PR (updated for commit 7d974da):

https://flutter-docs-prod--pr11924-mixinguide-k0m880qz.web.app

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

new 'layoutInfo' getter to implement.
---

## Summary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I remember this sounds all correct. I do wonder, though, if we should re-add a class RenderConstrainedLayoutBuilder with a default implementation of layoutInfo to reduce churn and make this not breaking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh way better, let me look into this today. Thank you @goderbauer!

@Piinks Piinks marked this pull request as draft April 23, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderConstrainedLayoutBuilder not found in Flutter Beta channel (3.32)
4 participants