Skip to content

Filter by close icon added for mobile screen #12008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Filter by close icon added for mobile screen #12008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fc2947
Filter by close icon added for mobile screen
zalabhavy May 13, 2025
35986d6
Merge branch 'main' into filterby
zalabhavy May 19, 2025
c6803b3
Update filter by UI with close button and mobile fixes
zalabhavy Aug 29, 2025
30c70c5
Merge branch 'main' into filterby
zalabhavy Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/_includes/docs/learning-resources-index/side-filters.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
<input type="checkbox" id="close-filter-toggle" hidden>
<div id="resource-filter-group-wrapper">
<div id="resource-filter-group">
<div class="filter-header">
<label for="close-filter-toggle" class="close-icon" aria-hidden="true">
<span class="material-symbols">close</span>
</label>
</div>
<div class="filter-header">
<label for="close-filter-toggle" class="close-icon" aria-hidden="true">
<span class="material-symbols">close</span>
</label>
</div>
<div class="table-title">Filter by</div>
<div class="table-content">
<h4>Subject</h4>
Expand Down Expand Up @@ -33,3 +45,5 @@
</ul>
</div>
</div>
</div>
</div>
51 changes: 37 additions & 14 deletions src/content/assets/js/learning-resources-index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,21 +265,43 @@ function _setupDropdownMenu() {
if (!pageContent) return;

const filtersButton = pageContent.querySelector('.show-filters-button');
const filtersEl = pageContent.querySelector('.right-col');
const filtersEl = document.getElementById('resource-filter-group-wrapper') || pageContent.querySelector('.right-col');
const closeToggleCheckbox = document.getElementById('close-filter-toggle');

if (!filtersButton || !filtersEl) return;

function _closeMenu() {
filtersEl.classList.remove('show');
filtersButton.ariaExpanded = 'false';
if (closeToggleCheckbox) {
closeToggleCheckbox.checked = true;
} else {
filtersEl.classList.remove('show');
}
filtersButton.ariaExpanded = 'false';
}

function _openMenu() {
if (closeToggleCheckbox) {
closeToggleCheckbox.checked = false;
} else {
filtersEl.classList.add('show');
}
filtersButton.ariaExpanded = 'true';
}

filtersButton.addEventListener('click', (_) => {
if (filtersEl.classList.contains('show')) {
_closeMenu();
function _isMenuOpen() {
if (closeToggleCheckbox) {
return !closeToggleCheckbox.checked;
} else {
filtersEl.classList.add('show');
filtersButton.ariaExpanded = 'true';
return filtersEl.classList.contains('show');
}
}

filtersButton.addEventListener('click', (_) => {
if (_isMenuOpen()) {
_closeMenu();
} else {
_openMenu();
}
});

document.addEventListener('keydown', (event) => {
Expand All @@ -290,12 +312,13 @@ function _setupDropdownMenu() {

// Close the dropdown if anywhere not in the filters menu is.
const content = document.getElementById('all-resources-grid');
content.addEventListener('click', (_) => {
if (!filtersEl.classList.contains('show')) {
return;
}
_closeMenu();
});
if (content) {
content.addEventListener('click', () => {
if (_isMenuOpen()) {
_closeMenu();
}
});
}
}

function shuffleElements(container) {
Expand Down