-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[3.38] add web-dev-config file description #12232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to double check. This PR relates to the next stable release, yes?
Break at 80 chars or less (actually, we prefer semantic line breaks).
Avoiding the exclamation points. We are typically more subdued (and humble) than that. ;)
Breaking up long lines _and_ changing verbs to current tense.
Making the list parallel. Actually, I should have removed that comma after path in the second item.
/gcbrun |
Visit the preview URL for this PR (updated for commit e00eedd): https://flutter-docs-prod--pr12232-web-dev-config-v2873je6.web.app |
Yup! Just getting it ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! But, can you also add this to the index file?
Just did! |
Adding documentation for the web-dev-config file, a centralized file to configure web development server settings