Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Dec 15, 2025

When updating a Flutter on Android app from an AGP version < 9.0.0 to an AGP version 9.0.0+, the app will not build sucessfully. This breaking changes doc outlines how to migrate Gradle build files to successfully build with AGP 9.0.0+.

Trying to get these docs published before AGP 9 officially on redacted

Resolves flutter/flutter#179914

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jesswrd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds essential documentation to guide Flutter developers through the process of updating their applications to be compatible with Android Gradle Plugin 9.0.0 and subsequent versions. It addresses critical breaking changes related to Kotlin plugin usage and AGP's Domain Specific Language (DSL), providing clear migration paths to ensure successful builds and continued functionality.

Highlights

  • New Documentation for AGP 9: This pull request introduces a new documentation page detailing the breaking changes and necessary migration steps for Flutter applications when upgrading to Android Gradle Plugin (AGP) 9.0.0 and later versions.
  • Kotlin Plugin Migration: The documentation provides instructions on how to migrate from the kotlin-android plugin to the built-in Kotlin support, including removing the old plugin and kotlinOptions block, and replacing it with the new kotlin { compilerOptions { jvmTarget = ... } } syntax in android/app/build.gradle or .kts files.
  • AGP DSL Compatibility: It outlines the need to set the android.newDsl=false flag in android/gradle.properties to ensure compatibility with older AGP DSL types, as AGP 9+ primarily uses new DSL interfaces.
  • Flutter Version Support: The document clarifies that Flutter 3.40.0 added support for AGP 9+, but projects created with earlier Flutter versions will require manual migration following the provided steps.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jesswrd jesswrd changed the title Added Docs for AGP 9 [WIP] Added Docs for AGP 9 Dec 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for migrating Flutter apps to support Android Gradle Plugin 9.0.0+. The new guide is clear and provides helpful code snippets. I've made a few suggestions to correct some factual errors in plugin and property names, and to improve wording and formatting for better clarity and adherence to the project's documentation style guide. Specifically, I've pointed out an incorrect Kotlin plugin name, a typo in a Gradle property, use of a first-person pronoun, and several places where semantic line breaks could be improved.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 15, 2025

Visit the preview URL for this PR (updated for commit 2fde26e):

https://flutter-docs-prod--pr12825-agp-9-docs-wu1mvmd3.web.app

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing flutter/flutter#179765 so just leaving some thoughts on this!

@jesswrd jesswrd changed the title [WIP] Added Docs for AGP 9 Added Docs for AGP 9 Dec 16, 2025
@jesswrd jesswrd marked this pull request as ready for review December 16, 2025 17:56
@jesswrd jesswrd requested review from a team and sfshaza2 as code owners December 16, 2025 17:57
@jesswrd jesswrd requested a review from camsim99 December 16, 2025 22:04
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for submitting this, @jesswrd! I have some minor edits. Also, can you add this to the index file in this directory? I assume you don't want to land this PR until the next stable release, yes?

## Timeline

Support in stable release: 3.40.0
Recommended in stable release: 3.43.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "recommended in stable release: xxx" mean? Does it mean that they should make these changes by this release?

Copy link
Contributor Author

@jesswrd jesswrd Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. AGP 9 is actually not automatically supported/used/included in newly created Flutter apps yet. It will be in a future release after AGP 9 is officially released to stable after redacted. I updated the timeline section accordingly.

github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 17, 2025
Added Flutter errors that direct users to Updating to AGP 9 Flutter
docs. The doc outlines the changes that must be made in order to
successfully build Flutter apps on Android using AGP 9+.

As of this moment, the doc has yet to be written. The errors just have
to be cherry picked to stable and beta by Tuesday, 12/16. The Flutter
doc PR [here](flutter/website#12825) can land
later.

Resolves #179914

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Comment on lines +24 to +25
In a future Flutter release, support will be added for applying AGP 9+.
For now, all projects must be migrated manually.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this part. Support for AGP 9 will be added in a future release and not in 3.40.0.

@jesswrd jesswrd requested a review from sfshaza2 December 17, 2025 20:37
@jesswrd
Copy link
Contributor Author

jesswrd commented Dec 17, 2025

Thanks so much for submitting this, @jesswrd! I have some minor edits. Also, can you add this to the index file in this directory? I assume you don't want to land this PR until the next stable release, yes?

The AGP 9 migration docs do not depend on a Flutter release. Anyone updating to the AGP 9 alphas or betas could see the Android errors and use these docs right now. Basically, these docs can be published immediately.

github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 17, 2025
Need to fix-forward website url. Minor change from 
`https://docs.flutter.dev/release/breaking-changes/update-to-AGP-9` to 
`https://docs.flutter.dev/release/breaking-changes/migrate-to-agp-9`

Should align with the file convention from this website PR:
flutter/website#12825

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Added Flutter errors that direct users to Updating to AGP 9 Flutter
docs. The doc outlines the changes that must be made in order to
successfully build Flutter apps on Android using AGP 9+.

As of this moment, the doc has yet to be written. The errors just have
to be cherry picked to stable and beta by Tuesday, 12/16. The Flutter
doc PR [here](flutter/website#12825) can land
later.

Resolves flutter#179914

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Need to fix-forward website url. Minor change from 
`https://docs.flutter.dev/release/breaking-changes/update-to-AGP-9` to 
`https://docs.flutter.dev/release/breaking-changes/migrate-to-agp-9`

Should align with the file convention from this website PR:
flutter/website#12825

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Added Flutter errors that direct users to Updating to AGP 9 Flutter
docs. The doc outlines the changes that must be made in order to
successfully build Flutter apps on Android using AGP 9+.

As of this moment, the doc has yet to be written. The errors just have
to be cherry picked to stable and beta by Tuesday, 12/16. The Flutter
doc PR [here](flutter/website#12825) can land
later.

Resolves flutter#179914

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Need to fix-forward website url. Minor change from 
`https://docs.flutter.dev/release/breaking-changes/update-to-AGP-9` to 
`https://docs.flutter.dev/release/breaking-changes/migrate-to-agp-9`

Should align with the file convention from this website PR:
flutter/website#12825

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Added Flutter errors that direct users to Updating to AGP 9 Flutter
docs. The doc outlines the changes that must be made in order to
successfully build Flutter apps on Android using AGP 9+.

As of this moment, the doc has yet to be written. The errors just have
to be cherry picked to stable and beta by Tuesday, 12/16. The Flutter
doc PR [here](flutter/website#12825) can land
later.

Resolves flutter#179914

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
jesswrd added a commit to jesswrd/flutter that referenced this pull request Dec 18, 2025
Need to fix-forward website url. Minor change from 
`https://docs.flutter.dev/release/breaking-changes/update-to-AGP-9` to 
`https://docs.flutter.dev/release/breaking-changes/migrate-to-agp-9`

Should align with the file convention from this website PR:
flutter/website#12825

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Second, AGP 9+ will only use the new AGP DSL interfaces.
This means any old DSL types will not be properly read.
The Flutter team is working on migrating old DSL types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the bug that tracks that work (if there is not one create one)

must be applied. As of AGP 9.0.0,
the following migrations are required to successfully apply AGP 9+.

First, built-in Kotlin is the new default, meaning any apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the summary should have steps since we have detailed steps below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the summary adds value because it explains what is going to be migrated and why it should be migrated in more detail than the actual migration steps below.

I think I'm not seeing what steps exist in the summary. When you say steps, do you mean the "first" and "second" wording?

You should also use the minimum compatible dependency versions
listed in the [Android Gradle Plugin docs][AGP block].

### Update the Gradle file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this title have the actual file that should be updated? Ex app/build.gradle(.kts)?

Copy link
Contributor Author

@jesswrd jesswrd Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had what you suggested as the title before revisions: #12825 (comment). The actual file to be udpated is below in the directions.


## Timeline

In stable release: TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider including a bug number or link instead of tbd.

Copy link
Contributor Author

@jesswrd jesswrd Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I can be more clear in that section. Basically AGP 9 will be automatically supported in newly created Flutter apps starting the release after whenever AGP 9 is officially released. Idk what that release version is. I can create an issue outiling this and link the bug number.

In stable release: TBD (for more details, see issue <issue-number>)

harryterkelsen added a commit to harryterkelsen/flutter that referenced this pull request Dec 19, 2025
commit 96ae88f3980a590ea3b55e6fbf0ac5ffce78c202
Author: Srujan Gaddam <[email protected]>
Date:   Fri Dec 19 10:15:01 2025 -0800

    Pass canaryFeatures to BuildSettings (#180108)

    Previously, this made little difference as DWDS used this only in one
    case with expression evaluation but now that the load strategies have
    diverged based on this flag, we should correctly always pipe this flag.
    This fixes an issue with a future DWDS version.

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

commit 0e9461ea4aef6675ed8ed87298985e308540af67
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 13:05:55 2025 -0500

    Roll Skia from fe2be289c9fe to ae5dd72b3591 (1 revision) (#180129)

    https://skia.googlesource.com/skia.git/+log/fe2be289c9fe..ae5dd72b3591

    2025-12-19 [email protected] [graphite] Fix PaintParamsTestUtils
    folder

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 4df70366d409f95a64af62079ed7f14bcfbf1d5d
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 10:46:26 2025 -0500

    Roll Packages from 6f392aaa748f to f28cf2e28261 (1 revision) (#180124)

    https://github.com/flutter/packages/compare/6f392aaa748f...f28cf2e28261

    2025-12-18 [email protected]
    [video_player_android] update pigeon to 26.1.5 (flutter/packages#10644)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit a38f2f3fe6d521fd3eacb6cdb7d05874bf7cfd07
Author: richardexfo <[email protected]>
Date:   Fri Dec 19 10:20:58 2025 -0500

    Set text input purpose and hints on Linux platform (#180013)

    For GTK+3 the purpose and hints of a Text Input are set through
    properties of the Input Method g_object. The properties have to be
    extracted from the inputType configuration.
    This affects virtual keyboards on Linux.

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit 2f7e4e773d3d31dfc41b19856c6b45b39d4bfc56
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 09:31:28 2025 -0500

    Roll Dart SDK from 6b5a8543c5db to cfc117d10d36 (1 revision) (#180122)

    https://dart.googlesource.com/sdk.git/+log/6b5a8543c5db..cfc117d10d36

    2025-12-19 [email protected]
    Version 3.11.0-262.0.dev

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 8663dcc606ab116e0f1c0cfd3b5aa422c3dbfbb4
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 03:58:34 2025 -0500

    Roll Skia from 7c08f3aae5eb to fe2be289c9fe (2 revisions) (#180114)

    https://skia.googlesource.com/skia.git/+log/7c08f3aae5eb..fe2be289c9fe

    2025-12-19 [email protected] Roll ANGLE
    from cccce3804751 to 110aa16f60f8 (4 revisions)
    2025-12-19 [email protected] Roll
    vulkan-deps from 9520a964ce93 to 446fd082c121 (7 revisions)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 704210e4768a8487ac9ba8de67c4635ca2418608
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 02:02:25 2025 -0500

    Roll Skia from ebd15e2be7e6 to 7c08f3aae5eb (1 revision) (#180112)

    https://skia.googlesource.com/skia.git/+log/ebd15e2be7e6..7c08f3aae5eb

    2025-12-19 [email protected] Roll Dawn
    from d8841af06a44 to e78ae5f04508 (9 revisions)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 037e8a089162484d364b53cd41e21fd377cd9fac
Author: engine-flutter-autoroll <[email protected]>
Date:   Fri Dec 19 00:46:42 2025 -0500

    Roll Fuchsia Linux SDK from GDafA59oVvumkFg3-... to oe10epXkqGnv21AbZ... (#180110)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC [email protected],[email protected] on the revert to ensure
    that a human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 1fd550205879ccedc6e725673b5dc7411024bba4
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 22:36:31 2025 -0500

    Roll Dart SDK from 0d1101384be7 to 6b5a8543c5db (1 revision) (#180109)

    https://dart.googlesource.com/sdk.git/+log/0d1101384be7..6b5a8543c5db

    2025-12-19 [email protected]
    Version 3.11.0-261.0.dev

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 9221947b01b760676b6912651a000a8b467461b5
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 20:28:27 2025 -0500

    Roll Skia from bbadc90717c3 to ebd15e2be7e6 (7 revisions) (#180104)

    https://skia.googlesource.com/skia.git/+log/bbadc90717c3..ebd15e2be7e6

    2025-12-19
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-12-18 [email protected] Reland "[rust bmp] Initial implementation
    of rust icc FFI using moxcms crate"
    2025-12-18
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-12-18 [email protected] Remove failing tests from Win11
    jobs
    2025-12-18 [email protected] exclude public configs when optional
    template evaluates to false
    2025-12-18
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-12-18 [email protected] Compile CanvasKit with Bazel using
    c++20

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit f4ce6453636f914dca2abe1494d940e49d5a03e2
Author: flutter-pub-roller-bot <[email protected]>
Date:   Thu Dec 18 15:16:30 2025 -0800

    Roll pub packages (#180097)

    This PR was generated by `flutter update-packages --force-upgrade`.

commit 9c47d57dbb38ec552959b2272ab31fdff911ba87
Author: gaaclarke <[email protected]>
Date:   Thu Dec 18 15:04:55 2025 -0800

    Fix rotated image filter shader (#180027)

    fixes https://github.com/flutter/flutter/issues/179918

    This blocks us from rerasterizing if there is a rotation on the
    imagefilter being drawn. This restores the behavior before
    https://github.com/flutter/flutter/commit/c089837469a3676dd5dafe7886f6971aff2649c3
    while keeping the golden introduced in that pr working.

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit 26978a3a452fed0e684a31357263a69e5c7833cd
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 17:39:41 2025 -0500

    Roll Dart SDK from b1c33eb67214 to 0d1101384be7 (6 revisions) (#180093)

    https://dart.googlesource.com/sdk.git/+log/b1c33eb67214..0d1101384be7

    2025-12-18 [email protected]
    Version 3.11.0-260.0.dev
    2025-12-18 [email protected]
    Version 3.11.0-259.0.dev
    2025-12-18 [email protected]
    Version 3.11.0-258.0.dev
    2025-12-18 [email protected]
    Version 3.11.0-257.0.dev
    2025-12-17 [email protected]
    Version 3.11.0-256.0.dev
    2025-12-17 [email protected]
    Version 3.11.0-255.0.dev

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 162ced574f716e3f2e9135a2b28db09b9749d945
Author: Ahmed Mohamed Sameh <[email protected]>
Date:   Fri Dec 19 00:02:22 2025 +0200

    Make sure that a CupertinoTextSelectionToolbarButton doesn't crash in… (#179995)

    This is my attempt to handle
    https://github.com/flutter/flutter/issues/6537 for the
    CupertinoTextSelectionToolbarButton widget.

commit 420a32438c7599b5e1a1fbc550f12ac1d89702b2
Author: chunhtai <[email protected]>
Date:   Thu Dec 18 13:56:40 2025 -0800

    wires up SetSemanticsTreeEnabled to android accessibility bridge (#177954)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->

    Before the change, the bridge only listens to updateSemantics when it
    receives signal from the OS

    After the change, the bridge always listens to updateSemantics, but will
    clear out caches when SetSemanticsTreeEnabled is called with false

    ## Pre-launch Checklist

    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

    ---------

    Co-authored-by: Matt Boetger <[email protected]>

commit 0c98a23140421fdbff18b18c8487327382e5b01e
Author: Franklyn Roberto <[email protected]>
Date:   Thu Dec 18 18:46:59 2025 -0300

    fix: Enable mouse drag for RefreshIndicator.noSpinner example (#180066)

    This PR adds `scrollBehavior` to the `RefreshIndicator.noSpinner` sample
    to allow mouse dragging on desktop platforms, addressing the issue where
    it was impossible to trigger the refresh with a mouse.

    Fixes #179711

commit 783e3191d89acbd2e58d44e6de94ae95b97ab693
Author: Tong Mu <[email protected]>
Date:   Thu Dec 18 13:41:49 2025 -0800

    Remove an obsolete TODO in DataTable (#180033)

    When the `InkWell` was added, it was used only for a gesture callback,
    and at that time the InkWell should only be added when the gesture
    callback was needed. Due to an issue, we couldn't swap out the child
    widget dynamically.

    Even though that the issue has been fixed, the `InkWell` is considered
    mandatory since it is now used by two more properties. (Theoretically we
    can check if any of the 3 properties is needed to add this `InkWell`,
    but I think that's too much.)

    ## Pre-launch Checklist

    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit f7a5bacf48313e67145ac658f11bdcc6e6897ad3
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 16:03:23 2025 -0500

    Roll Skia from 6d3aedbd0b0b to bbadc90717c3 (1 revision) (#180083)

    https://skia.googlesource.com/skia.git/+log/6d3aedbd0b0b..bbadc90717c3

    2025-12-18 [email protected] Revert "[rust bmp] Initial
    implementation of rust icc FFI using moxcms crate"

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit f804fb5b4e8e4dc4700c00bab07b2a204c1d0433
Author: Jackson Gardner <[email protected]>
Date:   Thu Dec 18 12:57:15 2025 -0800

    Add explicit `--cross-origin-isolation` flag to `flutter run`. (#180026)

    Fixes https://github.com/flutter/flutter/issues/163479

    This adds a flag,
    `--cross-origin-isolation`/`--no-cross-origin-isolation` that allows the
    user to explicitly control whether `flutter run`/`drive`/`test` serves
    files with COOP/COEP headers. If the user doesn't specify, it uses cross
    origin isolation when wasm is enabled and no cross origin isolation when
    wasm is disabled.

commit 0271623e8eefea83a359bb7e21fca07c80087960
Author: flutter-pub-roller-bot <[email protected]>
Date:   Thu Dec 18 12:55:49 2025 -0800

    Roll pub packages (#180082)

    This PR was generated by `flutter update-packages --force-upgrade`.

commit ca986c3900aa8fb21ea82fc293765a0888198844
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 12:48:38 2025 -0500

    Roll Skia from 79b0fdbadb72 to 6d3aedbd0b0b (1 revision) (#180073)

    https://skia.googlesource.com/skia.git/+log/79b0fdbadb72..6d3aedbd0b0b

    2025-12-18 [email protected] Roll
    vulkan-deps from f5dca66a1664 to 9520a964ce93 (1 revision)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 5632701286ca0f6fa4249f69fe2041b7c27fd9a8
Author: gaaclarke <[email protected]>
Date:   Thu Dec 18 09:04:34 2025 -0800

    Moved high bitrate texture tests to engine (#179906)

    This adds a few goldens where skia supports the file format. This is a
    bit more scalable and direct than managing integration tests.

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit 052435ce7b60ff5e4d076dd5806e40ccf86c9ada
Author: Mohellebi abdessalem <[email protected]>
Date:   Thu Dec 18 17:32:50 2025 +0100

    Remove unnecessary @RequiresApi annotations in `FlutterView.java` (#180051)

    after #175508 has Landed some of these warnings started to appear:
    <img width="471" height="234" alt="save_0"
    src="https://github.com/user-attachments/assets/f3ef3e61-861e-456e-a7ec-f2315db742bc"
    />

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit c967b4dc28bff118e6fa1601d416a8534d0fd250
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 10:52:26 2025 -0500

    Roll Packages from 57725eb05e91 to 6f392aaa748f (2 revisions) (#180070)

    https://github.com/flutter/packages/compare/57725eb05e91...6f392aaa748f

    2025-12-18 [email protected] [pigeon] Fix
    kotlin warning about calling bridge method (flutter/packages#10632)
    2025-12-18 [email protected] [camera_avfoundation] Wrappers
    swift migration - part 4 (flutter/packages#10440)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 070d238e0e9a3b51757eb0737c9a6dc4a7ccb1a4
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 09:50:23 2025 -0500

    Roll Skia from 5b6a9ad40e07 to 79b0fdbadb72 (1 revision) (#180064)

    https://skia.googlesource.com/skia.git/+log/5b6a9ad40e07..79b0fdbadb72

    2025-12-18 [email protected] Manual roll
    Dawn from 8bfb54adc1de to d8841af06a44 (7 revisions)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 4717a648984111a7a1a77818dcdf01b12884274c
Author: Kostia Sokolovskyi <[email protected]>
Date:   Thu Dec 18 10:03:20 2025 +0100

    Add Slider.showValueIndicator property. (#179661)

    Closes https://github.com/flutter/flutter/issues/179660

    ### Description

    - Adds `Slider.showValueIndicator` property
    - Adds test to verify that `Slider.showValueIndicator` takes priority
    over `SliderTheme.showValueIndicator`

    ## Pre-launch Checklist

    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

    ---------

    Co-authored-by: Qun Cheng <[email protected]>

commit 5d8b59b533734da6f905d95bdc407e8111caca5f
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 02:38:26 2025 -0500

    Roll Skia from 6b81ab2e2a96 to 5b6a9ad40e07 (2 revisions) (#180045)

    https://skia.googlesource.com/skia.git/+log/6b81ab2e2a96..5b6a9ad40e07

    2025-12-18 [email protected] Roll ANGLE
    from 4f4f02fe5be1 to cccce3804751 (1 revision)
    2025-12-18 [email protected] Roll Dawn
    from 02bbb24c16b4 to 8bfb54adc1de (28 revisions)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 1d799b8c26fa9766dd97d53cf1f186752a0530c0
Author: engine-flutter-autoroll <[email protected]>
Date:   Thu Dec 18 00:35:12 2025 -0500

    Roll Skia from 26ab4090efd9 to 6b81ab2e2a96 (2 revisions) (#180042)

    https://skia.googlesource.com/skia.git/+log/26ab4090efd9..6b81ab2e2a96

    2025-12-18
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    2025-12-18
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 4bd1021d75eb2bd40de79ba56bb5016736720791
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Dec 17 22:34:25 2025 -0500

    Roll Fuchsia Linux SDK from fAoyBAT99XxwPE5hL... to GDafA59oVvumkFg3-... (#180036)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC [email protected],[email protected] on the revert to ensure
    that a human
    is aware of the problem.

    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit c4cacfa70303b113a35ccb0c7136e7f4074081c7
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Dec 17 22:30:36 2025 -0500

    Roll Skia from e1fd1817a82d to 26ab4090efd9 (1 revision) (#180035)

    https://skia.googlesource.com/skia.git/+log/e1fd1817a82d..26ab4090efd9

    2025-12-18 [email protected] Roll
    vulkan-deps from 1745c51c6d9c to f5dca66a1664 (5 revisions)

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 5326a43787399477b0cc3b83413ce207c0093aba
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Dec 17 19:54:07 2025 -0500

    Roll Skia from c07d1f68790f to e1fd1817a82d (1 revision) (#180028)

    https://skia.googlesource.com/skia.git/+log/c07d1f68790f..e1fd1817a82d

    2025-12-17 [email protected] [graphite] Separate input generation from
    PaintParamsKeyTest

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 5fa6c12bbbd03139e6dae2674e313cf833e00042
Author: Tong Mu <[email protected]>
Date:   Wed Dec 17 15:19:24 2025 -0800

    Improve the documentation of `Card` (#178834)

    The documentation of `Card` isn't clear enough on some properties and
    the differences between the constructors.

    Fixes https://github.com/flutter/flutter/issues/178611.

    ## Pre-launch Checklist

    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

    ---------

    Co-authored-by: Victor Sanni <[email protected]>

commit 2c90366b7d12650e4f17298f61f854de1027be4a
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Dec 17 17:31:14 2025 -0500

    Roll Skia from 0a0079a5741d to c07d1f68790f (1 revision) (#180019)

    https://skia.googlesource.com/skia.git/+log/0a0079a5741d..c07d1f68790f

    2025-12-17
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 103dfa6c356ae7d3d9297da7de26020a558d206a
Author: Matt Boetger <[email protected]>
Date:   Wed Dec 17 14:29:38 2025 -0800

    Revert "Revert "Android implementation of content sizing"" (#179753)

    Reverts flutter/flutter#179698

    Relands Content Sizing

    Android Embedder implementation of content sizing.

    Fixes: https://github.com/flutter/flutter/issues/149033

commit aafc9259583c7857578c23eace21e3a7564f8b80
Author: jesswrd <[email protected]>
Date:   Wed Dec 17 14:18:25 2025 -0800

    [AGP 9] Fix-Forward Website URL (#180018)

    Need to fix-forward website url. Minor change from
    `https://docs.flutter.dev/release/breaking-changes/update-to-AGP-9` to
    `https://docs.flutter.dev/release/breaking-changes/migrate-to-agp-9`

    Should align with the file convention from this website PR:
    https://github.com/flutter/website/pull/12825

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit 47b1f5f5c2a13311c9814633d2f04b14077af525
Author: JeelChandegra <[email protected]>
Date:   Thu Dec 18 02:33:14 2025 +0530

    Improve assertion messages in Tab widget for better clarity (#178295)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->

    *Replace this paragraph with a description of what this PR is changing
    or adding, and why. Consider including before/after screenshots.*

    *List which issues are fixed by this PR. You must list at least one
    issue. An issue is not required if the PR fixes something trivial like a
    typo.*

    *If you had to change anything in the [flutter/tests] repo, include a
    link to the migration guide as per the [breaking change policy].*

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

    ---------

    Co-authored-by: Tong Mu <[email protected]>

commit 54be2c98d5bcd43d77a3c585e3895544d00c1047
Author: engine-flutter-autoroll <[email protected]>
Date:   Wed Dec 17 15:30:36 2025 -0500

    Roll Skia from b1a087883bf0 to 0a0079a5741d (1 revision) (#180012)

    https://skia.googlesource.com/skia.git/+log/b1a087883bf0..0a0079a5741d

    2025-12-17 [email protected] [rust bmp] Initial implementation of
    rust icc FFI using moxcms crate

    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.

    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose

    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622

    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

commit 4f07d5021667c93113a67bf717311c886af04f71
Author: chunhtai <[email protected]>
Date:   Wed Dec 17 12:10:21 2025 -0800

    Clamps input value for progress indicator (#179898)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->

    Update the code to match the documentation

    ```
     /// A value of 0.0 means no progress and 1.0 means that progress is complete.
      /// The value will be clamped to be in the range 0.0-1.0.
    ```

    ## Pre-launch Checklist

    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit 297e7477d98273b3280738fb48cd269dfddf0a49
Author: Loïc Sharma <[email protected]>
Date:   Wed Dec 17 12:04:12 2025 -0800

    Update the Material `IconAlignment` sample (#179159)

    Migrates the samples to remove references to the deprecated
    `ButtonStyleButton.iconAlignment`.

    The sample doesn't actually use `ButtonStyleButton.iconAlignment`
    directly, but it does refer to it in docs.

    Addresses: https://github.com/flutter/flutter/issues/179149

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.

    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].

    **Note**: The Flutter team is currently trialing the use of [Gemini Code
    Assist for
    GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
    Comments from the `gemini-code-assist` bot should not be taken as
    authoritative feedback from the Flutter team. If you find its comments
    useful you can update your code accordingly, but if you are unsure or
    disagree with the feedback, please feel free to wait for a Flutter team
    member's review for guidance on which automated comments should be
    addressed.

    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

commit ef3dbceed24a4cf545d6b538916cbc8b44ce29d6
Author: Gray Mackall <[email protected]>
Date:   Wed Dec 17 10:14:14 2025 -0800

    Modify the `create_cipd_packages.sh` script to allow uploading multiple `build-tools` versions, and update to new bundle (#179963)

    1. modifies the script slightly to allow passing in multiple versions
    for a given element
    2. updates to build tools 36.1.0, and adds 35.0.0 and 34.0.0
    3. also adds cmake to the list, version 3.22.1, as that downloaded in
    our ci currently
    4. changes ci yaml and deps file accordingly

    ## Pre-launch Checklist

    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AGP 9] Add Docs to Migrate Android Build files to Sucessfully Build on AGP 9

5 participants