-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add definition for Embedder #12852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add definition for Embedder #12852
Conversation
Summary of ChangesHello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #12645 by enhancing the project's documentation. It introduces a new, detailed glossary entry for the term 'Embedder', providing clarity on its role as the platform-specific component managing the Flutter engine and its interactions with the operating system. This addition aims to improve understanding of Flutter's architecture for developers and readers. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new glossary entry for 'Embedder'. The definition is well-written and the provided links are relevant. I've suggested a minor update to the list of programming languages to improve technical accuracy and consistency with other documentation pages.
| It also manages the message event loop. | ||
| The embedder is written in a language appropriate for the platform, | ||
| such as Java/Kotlin for Android, Swift/Objective-C for iOS/macOS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition! For improved accuracy and consistency with the 'Flutter architectural overview' page, consider updating the list of languages. The overview page also mentions C++ for Android and Objective-C++ for iOS/macOS. Including them here would make the definition more complete and consistent.
such as Java/Kotlin and C++ for Android, Swift/Objective-C/Objective-C++ for iOS/macOS,|
Visit the preview URL for this PR (updated for commit f430c1f): https://flutter-docs-prod--pr12852-glossary-embedder-lnweun58.web.app |
Fixes #12645. Adds the glossary entry for 'Embedder' with relevant links.