feat: add comprehensive async tests and remove orientation variable i…#51
Merged
CaiJingLong merged 1 commit intomainfrom Aug 6, 2025
Merged
feat: add comprehensive async tests and remove orientation variable i…#51CaiJingLong merged 1 commit intomainfrom
CaiJingLong merged 1 commit intomainfrom
Conversation
…n JPEG decoder Signed-off-by: Caijinglong <cjl_spy@163.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive async testing for the image_size_getter package and removes an unused orientation variable assignment in the JPEG decoder implementation.
- Adds extensive async test coverage for all supported image formats (GIF, JPEG, PNG, WebP, BMP)
- Includes error handling tests for non-existent files and unsupported formats
- Removes unused orientation variable assignment in JPEG decoder
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/image_size_getter/test/image_size_getter_test.dart | Adds comprehensive async test suite covering all image formats and error scenarios |
| packages/image_size_getter/lib/src/decoder/impl/jpeg_decoder.dart | Removes unused orientation variable assignment and adds explanatory comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive async tests for the
ImageSizeGetterlibrary and refines the JPEG decoder logic to improve robustness and correctness. The main focus is on ensuring that asynchronous image size detection works reliably across a variety of formats and edge cases, while also improving the decoder's handling of JPEG files.Testing improvements
image_size_getter_test.dartto covergetSizeAsyncandgetSizeResultAsyncfor multiple image formats (GIF, JPEG, PNG, WebP, BMP), including extended and lossless WebP formats. These tests verify correct size detection and decoder identification.JPEG decoder improvements