add config library #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 81.70% 82.08% +0.38%
==========================================
Files 19 24 +5
Lines 3410 4834 +1424
==========================================
+ Hits 2786 3968 +1182
- Misses 624 866 +242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Eh, this PR probably needs to be split at this point. I'll do that. |
|
Re-pushed, built on top of |
Problem: libflux-conf will require libtomlc99. Pull in a copy from flux-core, with unit test and upstream inputs.
Problem: libflux-conf will require timestamp utils from flux-core. Pull them in with unit test.
Problem: the flux_conf_t class can be useful in multiple framework projects. Pull it in from libflux with its helper tomltk from libutil. Pull in their unit tests.
Problem: libflux-conf will need a pkgconfig file. Add one.
Problem: there are no man pages for flux_conf_t. Pull them in from flux-core. Also pull in json_pack/json_unpack descriptions they reference. Update dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the
flux_conf_tclass with its tomlc99 parser and json conversion from flux-core.Also a few missing unit tests are added.