Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an advanced option to skip any Gemfile updates #95

Merged
merged 1 commit into from
May 8, 2024
Merged

Add an advanced option to skip any Gemfile updates #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ There may be times where feature detection plus flags just aren't enough. As an

* `--instructions=path` - a dockerfile fragment to be inserted into the final document.
* `--migration=cmd` - a replacement (generally a script) for `db:prepare`/`db:migrate`.
* `--no-gemfile-updates` - do not modify my gemfile.
* `--procfile=path` - a [Procfile](https://github.com/ddollar/foreman#foreman) to use in place of launching Rails directly.

Like with environment variables, packages, and build args, `--instructions` can be tailored to a specific build phase by adding `-base`, `-build`, or `-deploy` after the flag name, with the default being `-deploy`.
Expand Down
6 changes: 6 additions & 0 deletions lib/generators/dockerfile_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class DockerfileGenerator < Rails::Generators::Base
"ci" => false,
"compose" => false,
"fullstaq" => false,
"gemfile-updates" => true,
"jemalloc" => false,
"label" => {},
"link" => true,
Expand Down Expand Up @@ -219,6 +220,9 @@ class DockerfileGenerator < Rails::Generators::Base
class_option "private-gemserver-domain", type: :string, default: OPTION_DEFAULTS["private-gemserver-domain"],
desc: "domain name of a private gemserver used when installing application gems"

class_option "gemfile-updates", type: :boolean, default: OPTION_DEFAULTS["gemfile-updates"],
desc: "include gemfile updates"


class_option "add-base", type: :array, default: [],
desc: "additional packages to install for both build and deploy"
Expand Down Expand Up @@ -510,6 +514,8 @@ def keeps?
end

def install_gems
return unless options["gemfile-updates"]

ENV["BUNDLE_IGNORE_MESSAGES"] = "1"

gemfile = IO.read("Gemfile")
Expand Down
Loading