Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nd): wind and speed display update rate for more frequent updates #9829

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(nd): wind and speed display update rate for more frequent updates #9829

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaedbeb
increase wind and speed update frequency from 2Hz to 10Hz
bulenteroglu Feb 5, 2025
a43f46f
update values
bulenteroglu Feb 6, 2025
ee445c3
update changelog
bulenteroglu Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@
1. [A380X/FMS] Add STEP ALTs tab on VERT REV page & auto step climb functionality - @flogross89 (floridude)
1. [A380X/FMS] Add selection of CLB/DES constraint if constraint type is unknown - @flogross89 (floridude)
1. [FMS] Fix approach ident only showing on ND when approach is being flown - @BravoMike99 (bruno_pt99)
1. [ND] Fix wind and speed display update rate for more frequent updates - @bulenteroglu (senolitam)

## 0.12.0

Expand Down
4 changes: 2 additions & 2 deletions fbw-common/src/systems/instruments/src/ND/ND.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ class SpeedIndicator extends DisplayComponent<{ bus: EventBus }> {

sub
.on('groundSpeed')
.atFrequency(2)
.atFrequency(10)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question to the maintainers, I had a gander around the codebase to see other values being used with atFrequency - I went with 10, it does the job but also wanted to make sure this value is sensible

Copy link
Member

@lukecologne lukecologne Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked it up and it seems the wind speed and direction are indeed transmitted every 100ms, so 10Hz is correct. Ground speed and true heading is transmitted every 40ms, and true airspeed every 125ms.
Although this is done at the level of the transmitting unit (i.e. IR/ADR) in the real aircraft

.handle((value) => this.groundSpeedRegister.setWord(value));

this.groundSpeedRegister.sub((data) => {
Expand All @@ -543,7 +543,7 @@ class SpeedIndicator extends DisplayComponent<{ bus: EventBus }> {

sub
.on('trueAirSpeed')
.atFrequency(2)
.atFrequency(10)
.handle((value) => this.trueAirSpeedRegister.setWord(value));

this.trueAirSpeedRegister.sub((data) => {
Expand Down
6 changes: 3 additions & 3 deletions fbw-common/src/systems/instruments/src/ND/shared/WindIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class WindIndicator extends DisplayComponent<{ bus: EventBus }> {

sub
.on('windDirection')
.atFrequency(2)
.atFrequency(10)
.handle((value) => {
this.windDirectionWord.setWord(value);

Expand All @@ -43,7 +43,7 @@ export class WindIndicator extends DisplayComponent<{ bus: EventBus }> {

sub
.on('windSpeed')
.atFrequency(2)
.atFrequency(10)
.handle((value) => {
this.windSpeedWord.setWord(value);

Expand All @@ -54,7 +54,7 @@ export class WindIndicator extends DisplayComponent<{ bus: EventBus }> {

sub
.on('trueHeadingRaw')
.atFrequency(2)
.atFrequency(10)
.handle((value) => {
this.planeHeadingWord.setWord(value);
});
Expand Down
Loading