Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a32nx/fms): disallow create waypoint ident edits, not in db handling #9900

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Mar 9, 2025

Fixes #[issue_no]

Summary of Changes

  • Fixed an issue that prevented the create waypoint page being shown for NOT IN DATABASE.
  • Fixed an issue that prevented the RETURN working on the create waypoint page.
  • Removed null from the PilotWaypoint union type. | null should be explicit when it is needed, and it is not wanted except in the A380 code.
  • Add type and fix a bug it uncovered with the create waypoint callback.
  • The change I intended: Disallow editing of the ident once entered on the create waypoint page.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Go to the stored waypoints page and enter the ident for a new waypoint; try to press the LSK next to the ident a 2nd time and ensure you get NOT ALLOWED.
  • Create a flightplan and insert a waypoint on the F-PLN page that doesn't exist. Ensure you get NOT IN DATABASE in the scratchpad, and the create waypoint page. Press the RETURN LSK and ensure you go back to the F-PLN page with nothing new inserted.
  • Repeated the above but enter a location for the new waypoint and press STORE. Ensure that the waypoint is inserted into the plan and you are returned to the F-PLN page.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

tracernz added 5 commits March 9, 2025 16:12
Now the RETURN LSK on the create waypoint page will get you back where you came from.
We should explicitly union with null only where needed. DataManager never returns null.
@tracernz tracernz added this to the v0.13.0 milestone Mar 9, 2025
@tracernz tracernz requested a review from Benjozork March 9, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

2 participants