Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fms): cf leg after if leg case #9905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Mar 9, 2025

Fixes #[issue_no]

Summary of Changes

Fix the case of CF leg after an IF leg. The example case is KEWR EWR4/5.

Screenshots (if necessary)

Note: there is an issue with the TEB 214 VR leg fixed by #9801.
image

References

image

Additional context

Discord username (if different from GitHub):

Testing instructions

Test a selection of the following procedures on the ND to ensure the path looks correct:
TODO!

Fly at least one of them to ensure all the waypoints are sequenced correctly.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@tracernz tracernz added this to the v0.13.0 milestone Mar 9, 2025
Copy link
Member

@BlueberryKing BlueberryKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The testing instructions should also include flying one of the listed procedures to make sure the sequencing still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🟣 QA Review: Ready to Test
Development

Successfully merging this pull request may close these issues.

2 participants