Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give flyte binary cluster role permission to create service accounts #5579

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

shreyas44
Copy link
Contributor

Why are the changes needed?

  1. Flyte was failing to create service accounts on EKS since it didn't have permissions to do so
  2. The service account template in the Single Cluster Simple Cloud Deployment eks-starter.yaml file was failing for the above reason

What changes were proposed in this pull request?

Give the flyte binary cluster role permissions to create new service accounts.

How was this patch tested?

Tested on an internal kubernetes cluster.

Screenshots

Before:
Screenshot 2024-07-22 at 9 26 05 PM

After:
Screenshot 2024-07-22 at 9 49 23 PM

Signed-off-by: Shreyas Sreenivas <[email protected]>
Copy link

welcome bot commented Jul 23, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eapolinario eapolinario enabled auto-merge (squash) July 23, 2024 22:48
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.90%. Comparing base (02a0d2e) to head (d361c17).
Report is 121 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5579      +/-   ##
==========================================
+ Coverage   33.99%   35.90%   +1.91%     
==========================================
  Files        1135     1301     +166     
  Lines      102001   109396    +7395     
==========================================
+ Hits        34678    39284    +4606     
- Misses      63719    66016    +2297     
- Partials     3604     4096     +492     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 53.73% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (?)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.75% <ø> (ø)
unittests-flytestdlib 55.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 4514860 into flyteorg:master Jul 23, 2024
54 of 55 checks passed
Copy link

welcome bot commented Jul 23, 2024

Congrats on merging your first pull request! 🎉

vlibov pushed a commit to vlibov/flyte that referenced this pull request Aug 16, 2024
Signed-off-by: Shreyas Sreenivas <[email protected]>
Signed-off-by: Vladyslav Libov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants