Add option to install CRD as a part of chart install in flyte-binary #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marrrcin <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
+1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5967 +/- ##
==========================================
+ Coverage 36.85% 36.95% +0.09%
==========================================
Files 1310 1310
Lines 131227 131401 +174
==========================================
+ Hits 48362 48555 +193
+ Misses 78668 78632 -36
- Partials 4197 4214 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-- PR suggestions Signed-off-by: marrrcin <[email protected]>
marrrcin
force-pushed
the
flyte-binary-crd-option
branch
from
ff9ae23
to
892c96e
Compare
davidmirror-ops
requested changes
Nov 7, 2024
| @@ -0,0 +1,32 @@ | |||
| {{- if not .Values.configuration.propeller.createCRDs }} | |||
There was a problem hiding this comment.
Suggested change
| {{- if not .Values.configuration.propeller.createCRDs }} | |
| {{- if .Values.configuration.propeller.createCRDs }} |
I think this should be the logic?
|
@marrrcin to address that |
…-- make helm Signed-off-by: marrrcin <[email protected]>
|
@davidmirror-ops pushed! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Due to strict RBAC policies in some k8s clusters, it's impossible to create
ClusterRolewith wide set of permissions for service account used inflyte-binarydeployment. A namespace-scopedRolecould be used, but it requires:RoleandRoleBinding(possible by creating a sub-chart)FlyteWorkflowCRD at runtime, after Helm installMore context: https://flyte-org.slack.com/archives/C01P3B761A6/p1729865751682139
What changes were proposed in this pull request?
helm installHow was this patch tested?
3.1. with
helm install-level CRDs creation enabled and propeller-level CRDs creation disabled.2.2. with
helm install-level CRDs creation disabled and propeller-level CRDs creation enabled.Setup process
See above.
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A