Reserve fields in execution protos

[eapolinario]

Tracking issue

NA

Why are the changes needed?

We are using these fields in Union.

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

• added: For new features.
• changed: For changes in existing functionality.
• deprecated: For soon-to-be-removed features.
• removed: For features being removed.
• fixed: For any bug fixed.
• security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

Summary by Bito

This pull request reworks execution protobuf definitions by reserving critical fields for union operations. The changes remove obsolete byte blocks, add new field definitions, and restructure byte sequences across Go and Python implementations. These modifications enhance the structure, forward compatibility, and extensibility of execution protos to support future union functionality.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 3

[flyte-bot]

Code Review Agent Run #4858fc

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: 5a154a3..5a154a3

  • flyteidl/gen/pb-go/flyteidl/admin/execution.pb.go
  • flyteidl/gen/pb_python/flyteidl/admin/execution_pb2.py
  • flyteidl/protos/flyteidl/admin/execution.proto
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

AI Code Review powered by

[flyte-bot]

Changelist by Bito

This pull request implements the following key changes.

Key Change

Files Impacted

Feature Improvement - Execution Proto Update

- execution.pb.go - Refactored and enhanced the execution proto definitions by removing deprecated byte sequences and updating reserved fields and union support for future improvements. - execution_pb2.py - Updated descriptor definitions and adjusted serialized offsets to match the new execution proto structure while ensuring consistency across language bindings. - execution.proto - Added reserved fields to the execution proto messages to facilitate union support and enable future extensibility.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (a2331bd) to head (5a154a3).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6321      +/-   ##
==========================================
- Coverage   58.50%   58.48%   -0.02%     
==========================================
  Files         937      937              
  Lines       71088    71088              
==========================================
- Hits        41587    41577      -10     
- Misses      26349    26359      +10     
  Partials     3152     3152              

Flag	Coverage Δ
unittests-datacatalog	59.06% <ø> (ø)
unittests-flyteadmin	56.27% <ø> (-0.03%)	⬇️
unittests-flytecopilot	30.99% <ø> (ø)
unittests-flytectl	64.70% <ø> (-0.06%)	⬇️
unittests-flyteidl	76.12% <ø> (ø)
unittests-flyteplugins	61.00% <ø> (ø)
unittests-flytepropeller	54.79% <ø> (ø)
unittests-flytestdlib	64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pingsutw]

#25 pushing layer 5f1ee22ffb5e 0.3s done
#25 ERROR: unauthorized: unauthenticated: User cannot be authenticated with the token provided.
------
pushing ghcr.io/flyteorg/flytekit:zMvYwgfq_Hz4g7dOmHdJ4w with docker:
------
ERROR: unauthorized: unauthenticated: User cannot be authenticated with the token provided.
Verbose mode on

The token might be outdated.

[pingsutw]

#6329 should fix it