Deduce cache version iff cache_version is not set
#2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
thomasjpfan
reviewed
Sep 7, 2024
| @@ -378,6 +381,21 @@ def wrapper(fn: Callable[P, Any]) -> PythonFunctionTask[T]: | |||
| return wrapper | |||
|
|
|||
|
|
|||
| def _deduce_cache_version(fn: Callable[P, Any]) -> str: | |||
There was a problem hiding this comment.
If the task uses an imported function, any updates to the imported function would not be captured by inspect.getsource:
from utils import helper
@task(cache=True)
def my_task(x: int):
x = my_helper(x)I think this is okay as long as we documented the behavior and tell users what to do.
There was a problem hiding this comment.
Yup. I think it's okay too. Could we also update the docstring for cache_version here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#770
Why are the changes needed?
We should decrease the burden to use a cache in the case of python tasks.
What changes were proposed in this pull request?
This PR calls inspect.getsource passing the task function as an argument, which loads the actual source code of the function and use that to use generate a string to represent the cache version.
Notice that any change to the function (including adding/removing a parameter, changing the docstring, rearranging/reindenting some code) is going to produce a new value. In other words, the function can be moved around in a file, but its contents cannot change, otherwise a new value is going to be generated.
How was this patch tested?
Unit tests and local executions.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link