Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types/generic alias - assert fix only #2743

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Sep 11, 2024

Tracking issue

flyteorg/flyte#5737

Why are the changes needed?

Please see issue. This only fixes the TypeEngine's assert type. Not sure what other issues there are with generic aliases yet. Please keep the GH issue open.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title Types/generic alias Types/generic alias - assert fix only Sep 11, 2024
@wild-endeavor wild-endeavor marked this pull request as ready for review September 11, 2024 11:45
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (ae9c6f8) to head (7a9d420).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/core/type_engine.py 82.85% 3 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (ae9c6f8) and HEAD (7a9d420). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (ae9c6f8) HEAD (7a9d420)
15 8
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
- Coverage   90.87%   81.10%   -9.77%     
==========================================
  Files          74      194     +120     
  Lines        3331    19756   +16425     
  Branches        0     4120    +4120     
==========================================
+ Hits         3027    16023   +12996     
- Misses        304     2991    +2687     
- Partials        0      742     +742     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit e3dc8f9 into master Sep 14, 2024
101 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants