Update pyflyte defaults to use --copy behavior #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
wild-endeavor
changed the title
Signed-off-by: Yee Hing Tong <[email protected]>
thomasjpfan
reviewed
Sep 20, 2024
| " Note this needs additional configuration, refer to the docs.", | ||
| ) | ||
| @click.option( | ||
| "--copy", | ||
| required=False, | ||
| type=click.Choice(["all", "auto", "none"], case_sensitive=False), | ||
| default=None, # this will be changed to "none" after removing fast option | ||
| default="none", |
There was a problem hiding this comment.
As long as --fast is in the codebase, someone can still run --fast --copy auto, which is conflicting/confusing. I like keeping the default for copy as None and raising the current error.
When we actually remove --fast as an option, then I feel safe enough to set default="none".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This is the last of a series of PRs to clean up the fast register switches in the various
pyflytecommands. The main change was #2690This PR changes the default behavior for fast registration (invoked by
run,register, andpackageto use the new logic instead. Previously if the--copycommand was not specified, the old logic was still used. Only theserializecommand after this PR will use the old logic.What changes were proposed in this pull request?
How was this patch tested?
Locally tested and local executions run.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#2690
#2716
#2731
Docs link