Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteagent] All agents return dict instead of literal map #2762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 21, 2024

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

When users trace the code, they tend to follow patterns we use in Flytekit's agent. By allowing them to use dict instead of LiteralMap, we can improve their development experience. This way, they don't need to understand the details of how LiteralMap works or what a literal is.

What changes were proposed in this pull request?

In the agent's get request:

Before:

  • Returns a LiteralMap.

After:

  • Returns a dict.

Note: We will automatically handle the conversion from dict to LiteralMap for the user.

How was this patch tested?

Through unit tests.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant