fix release script to push version tags in correct format #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, so, we got back to a free plan, shame.
|
|
I’ll take of the first thing, updating the ci config
…On Fri, Oct 11, 2019 at 11:59 AM Denis Makogon ***@***.***> wrote:
Okay, so, we got back to a free plan, shame.
There are two things that must be fixed:
- get rid of caching in CI config (relatively easy)
- fix deploy keys as the CI is not capable to publish artefacts to the
PYPI.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101?email_source=notifications&email_token=AMIAMV22H6FP6XFQ5LRFWCLQODEHHA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA5G6Y#issuecomment-541184891>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMIAMVZJADKBFJPU34VUGG3QODEHHANCNFSM4I745TCQ>
.
|
|
Without fixing deploy keys this script would have no effect, sorry.
…On Fri, 11 Oct 2019 at 22:37, Rohit Kumar ***@***.***> wrote:
I’ll take of the first thing, updating the ci config
On Fri, Oct 11, 2019 at 11:59 AM Denis Makogon ***@***.***>
wrote:
> Okay, so, we got back to a free plan, shame.
> There are two things that must be fixed:
>
> - get rid of caching in CI config (relatively easy)
> - fix deploy keys as the CI is not capable to publish artefacts to the
> PYPI.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#101?email_source=notifications&email_token=AMIAMV22H6FP6XFQ5LRFWCLQODEHHA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA5G6Y#issuecomment-541184891
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AMIAMVZJADKBFJPU34VUGG3QODEHHANCNFSM4I745TCQ
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#101?email_source=notifications&email_token=AAXEX24VFTJZ4RSOZNSCXL3QODIYFA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBAGNQ#issuecomment-541197110>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXEX25HXJH3KMX7F7PWPK3QODIYFANCNFSM4I745TCQ>
.
|
|
can you provide more details on the deploy keys? I am not that familiar with how Circle CI and twine interact with pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the tag format being pushed by the release script to match the current convention, i.e. tags are in the format vX.X.X