fix: fix missing sponsor badge settings if they're not available #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Castillo <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the sponsor badge settings would fail when selected columns are not available in the current context. The fix ensures that unavailable options are filtered out to prevent rendering errors.
- Added null check in
ChipSelectInputto handle missing options gracefully - Filtered selected badge scan settings to only count available columns
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/mui/chip-select-input.js | Added null check to prevent rendering chips for unavailable options and improved variable naming consistency |
| src/components/forms/sponsor-general-form/badge-scan-settings.js | Filters selected columns to only count those that are available, preventing errors when settings reference unavailable columns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7tm871
Signed-off-by: Tomás Castillo [email protected]