MODSOURCE-859: Create new API POST /source-storage/records/{id}/un-delete #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiBordak
force-pushed
the
MODSOURCE-859
branch
from
fa9b862 to
48fc39c
Compare
AndreiBordak
requested review from
RomanChernetskyi,
KaterynaSenchenko,
pkjacob,
PBobylev,
askhat-abishev and
psmagin
pkjacob
reviewed
Feb 18, 2025
pkjacob
reviewed
Feb 18, 2025
pkjacob
reviewed
Feb 18, 2025
mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java
Outdated
Show resolved
Hide resolved
psmagin
reviewed
Feb 19, 2025
| @@ -421,6 +422,21 @@ public Future<Void> deleteRecordById(String id, IdType idType, Map<String, Strin | |||
| .compose(record -> updateRecord(record, okapiHeaders)).map(r -> null); | |||
| } | |||
|
|
|||
| @Override | |||
| public Future<Void> unDeleteRecordById(String id, IdType idType, Map<String, String> okapiHeaders) { | |||
There was a problem hiding this comment.
Does this method send domain event?
There was a problem hiding this comment.
Yes, it does. It publishes event in RecordDaoImpl
|
More code coverage is needed. Changes in RecordServiceImpl is not tested. |
|
@AndreiBordak there are 3 New issues |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Undelete feature for records
Approach
API
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.