Normalize nullish AcroForm text values to empty strings#1738
Draft
Copilot wants to merge 4 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix Acroforms issue with undefined field option
Normalize nullish AcroForm text values to empty strings
Jun 13, 2026
blikblum
requested changes
Jun 13, 2026
Comment on lines
+372
to
+376
| if (options[key] == null) { | ||
| options[VALUE_MAP[key]] = ''; | ||
| } else { | ||
| options[VALUE_MAP[key]] = options[key]; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (options[key] == null) { | |
| options[VALUE_MAP[key]] = ''; | |
| } else { | |
| options[VALUE_MAP[key]] = options[key]; | |
| } | |
| options[VALUE_MAP[key]] = options[key] ?? ''; |
simplify
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
undefinedintodoc.formText()could serialize the literal tokenundefinedinto the field dictionary, producing an invalid PDF that breaks parsers such as pdf-lib and iText RUPS. This change normalizes explicit nullish text values to empty strings so AcroForm output remains valid.AcroForm value normalization
value: undefined,value: null,defaultValue: undefined, anddefaultValue: nullas''during field dictionary construction.Regression coverage
formText()withundefinedandnullvalues.Example
Before, this could emit an invalid object value like
undefined. With this change, the field is serialized with an empty AcroForm value instead.