Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): collapse on clearable optional #3115

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Oct 26, 2024

Description

Added an option collapseOnClearable to collapse the dropdown upon clicking on the clearable icon

SUI does not collapse, but FUI does, so i made this option false by default so the behavior matches SUI.

Testcase

Closes

#3114

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug type/feat Any feature requests or improvements state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Oct 26, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Oct 26, 2024
@mvorisek
Copy link
Contributor

Thank you and I am happy with the default.

@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#516

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 26, 2024
@lubber-de lubber-de merged commit 14bf847 into fomantic:develop Oct 30, 2024
11 checks passed
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Oct 30, 2024
@lubber-de lubber-de deleted the collapseOnClearOptional branch October 30, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/bug Any issue which is a bug or PR which fixes a bug type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants