This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Displayed validators who have not voted for proposal yet #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwunyeung
suggested changes
Aug 5, 2021
imports/ui/proposals/Proposal.jsx
Outdated
| renderValidatorsWithoutVote() { | ||
| return <Result className="tally-result-detail" pose={this.state.open ? 'open' : 'closed'}> | ||
| <Card className='tally-result-table'> | ||
| {this.props.proposal.validatorsDidNotVote.list.map((vote, i) => |
There was a problem hiding this comment.
@MonikaCat can any of the objects here be undefined?
There was a problem hiding this comment.
Ok right, the value becomes undefined when it can't read the data from the db. I have updated the code to handle it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #355
Checklist
meteor npm run lintCHANGELOG.mdfile.Files changedin the Github PR explorer.