post a comment into the PR with the WI link #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git2Gus App is installed but the |
|
Thanks for the contribution! It looks like @brunano21 is an internal user so signing the CLA is not required. However, we need to confirm this. |
trinasfdx
reviewed
Nov 7, 2022
| @@ -40,6 +50,8 @@ const reqWithoutWorkItem = { | |||
|
|
|||
| describe('createChatterComment action', () => { | |||
| it('should call Issue.getName and Gus.createComment with workitem from title', async () => { | |||
| process.env.WORK_ITEM_BASE_URL = | |||
| 'https://gus.lightning.force.com/lightning/r/ADM_Work__c/'; | |||
There was a problem hiding this comment.
Can we add a test without having an explit link to gus.lightning.force.com? git2gus needs to work with Agile Accelerator - which is a product on AppExchange
There was a problem hiding this comment.
I could set process.env.WORK_ITEM_BASE_URL to any value actually. The test is just verifying that WORK_ITEM_BASE_URL is used to create the expected URL. I was following pattern seen into <root>/api/services/Issues/__test__/getWorkItemUrl.spec.js.
brunano21
requested review from
trinasfdx
and removed request for
klewis-sfdc and
gbockus-sf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.