perf: early exit for pathIsInfolder (19% faster)#732
perf: early exit for pathIsInfolder (19% faster)#732shetzel merged 10 commits intoforcedotcom:mainfrom
Conversation
lukecotter
changed the title
Will now pre process filePaths and group them by their packagedirectory. This prevents the same file being checked for inclusion in a directory when it has already been included in a previous directory.
|
hi @lukecotter thanks for the PR! |
|
@cristiand391 version 1.30.1 contains both of these |
|
thanks @lukecotter! |
|
@cristiand391 Now that v1.30.1 of isomorphic git has been adopted in #760 it would be great to get this in too so that the upstream sf cli libraries can benefit from both sets of performance improvements. |
|
Hi @cristiand391 and @WillieRuemmele is there anything you need from me to get this merged? |
|
@lukecotter - Can you please update the Also, please add unit tests for the code changes. |
|
@shetzel This is just a perf refactor so existing tests should cover everything as there is not behaviour change. I can have a look and cover any missing test cases though. |
|
@shetzel tests added too. |
…retrieve to 12.21.1 - @salesforce/core: 8.15.0 -> 8.18.1 - @salesforce/source-deploy-retrieve 12.20.1 -> 12.21.1
|
@shetzel |
4 participants
What does this PR do?
pathIsInfolder will exit as early as possible,.
This improved overall
sf project deploy starttimes in my project by ~19%What issues does this PR fix or reference?
Combined with this pull request in isomorphic git I was seeing roughly 45 - 50% faster times working out the changed files to deploy.
there are also some general improvements
If it is accepted it would be great to upgrade that too.
Do you want me to create an issue on the issues repo?