Fixed an issue where server config wasn't applied properly (#141)

forge-42 · Aug 24, 2024 · f64fe61 · f64fe61
1 parent eaf600e
commit f64fe61
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "remix-development-tools",
   "description": "Remix development tools - a set of tools for developing/debugging Remix.run apps",
   "author": "Alem Tuzlak",
-  "version": "4.3.1",
+  "version": "4.3.2",
   "license": "MIT",
   "keywords": [
     "remix",

diff --git a/src/server/config.ts b/src/server/config.ts
@@ -13,4 +13,4 @@ export interface DevToolsServerConfig {
 }
 
 export const defineServerConfig = (config: DevToolsServerConfig) => config; 
-export const getConfig = () => singleton("config", () => ({}) as DevToolsServerConfig);
+export const getConfig = () => typeof process !== "undefined" ? (process as any).rdt_config : singleton("config", () => ({}));
diff --git a/src/test-apps/remix-vite/vite.config.ts b/src/test-apps/remix-vite/vite.config.ts
@@ -9,10 +9,12 @@ const config = defineRdtConfig({
   panelLocation: "top",
   position: "top-right",
   requireUrlFlag: false
-  },server: {},
+  },server: {
+    silent: true,
+  },
   pluginDir: "./plugins",
   includeInProd: true,
-  unstable_console: true
+
 }, ); 
 export default defineConfig({
   plugins: [remixDevTools( config),remix({ future: {

diff --git a/src/vite/plugin.tsx b/src/vite/plugin.tsx
@@ -35,6 +35,10 @@ export const remixDevTools: (args?:RemixViteConfig) => Plugin[] = (args) => {
   const improvedConsole = args?.improvedConsole ?? true;
   const shouldInject = (mode: string | undefined) => mode === "development" || include;
   let port = 5173;
+  // Set the server config on the process object so that it can be accessed by the plugin
+  if(typeof process !== "undefined"){
+    (process as any).rdt_config = serverConfig;
+  }
   return [ 
     {
       enforce: "pre",
@@ -45,7 +49,7 @@ export const remixDevTools: (args?:RemixViteConfig) => Plugin[] = (args) => {
       transform(code) {
         const RDT_PORT = "__REMIX_DEVELOPMENT_TOOL_SERVER_PORT__";
         if (code.includes(RDT_PORT)) {
-          const modified = code.replaceAll(RDT_PORT, port.toString()).replaceAll(`singleton("config", () => ({}));`, `(${JSON.stringify(serverConfig)})`); 
+          const modified = code.replaceAll(RDT_PORT, port.toString()); 
           return modified;
         }
       },