FIO-10128: Fix styles when using the quick inline embed script#6126
Closed
yauheni-formio wants to merge 1 commit intomasterfrom
Closed
FIO-10128: Fix styles when using the quick inline embed script#6126yauheni-formio wants to merge 1 commit intomasterfrom
yauheni-formio wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Closing this PR, we need to find a way that doesn't move styles outside of the shadowdom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10128
Description
First of all everything for quick inline embed script renders inside of shadow dom. The problem appeared because in some cases (dropdown list of autocomplete or confirmation popup of sketchpad) we render elements (the dropdown list or confirmation popup) outside of shadow dom and as result we can't get access to this styles which accessible only inside of shadow dom. And a lot of styles related to this popup confirmation or autocomplete locate in formio.form.min.css. My solution allows to add this needed styles outside to make it work properly.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Manually
Checklist: