Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10359
Description
Fixed tests:
Should clear select value when "clear value on refresh options" and "refresh options on" is enable and number component is changed.The test was failed because this line was missed.OnBlur validation Should work properly with Select component. The test was failed because this PR was merged, but was not included into the buildShould not show unique API error when components with same keys are inside and outside of the Data component. The test is currently failing because this PR was merged into the 5.2.x branch of formio.js, but the corresponding dependency PR was not included in the version of @formio/core. The test will be fixed as soon as a new version of @formio/core includes this PRBreaking Changes / Backwards Compatibility
n/a
Dependencies
formio/core#255
How has this PR been tested?
Tests require new build for @formio/core. All tests pass locally
Checklist: