-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(translations): add german language #6234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We (ÖAMTC) talked with some of your colleagues about implementing german translations in Form.io, thus this PR was created. |
|
Hi @Hypnotist1148 thanks so much for the contribution! Unfortunately we've recently made some changes to our branches, which means this pull request is stale and needs to be updated. Would you be willing to update this PR so it can be merged into |
|
Hi @brendanbond, yes sure, will be on it probably by tomorrow. |
465cec4 to
9834b95
Compare
|
Hello, @brendanbond, this should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally
de: {
translation: fastCloneDeep(deTranslation)
}
should be added to src/i18n.js under resources. This allows for the use of the file
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-10611
Description
What changed?
This PR adds translations for the german language.
Why have you chosen this solution?
Because it matches the english translations.
Breaking Changes / Backwards Compatibility
This PR should not include breaking changes or impact backwards compatibility.
Dependencies
No dependencies were added.
How has this PR been tested?
I have not added any automated changes as this is only a translation.
Checklist: