[RTE-381] Pin to nightly-2025-02-22 compiler for some CI tests#713
Merged
[RTE-381] Pin to nightly-2025-02-22 compiler for some CI tests#713
nightly-2025-02-22 compiler for some CI tests#713Conversation
Collaborator
|
Hi @raoulstrackx when talking about CI, do you mean the CI in our internal jenkins sgx CI? |
Contributor
|
Yeah, since the CI is unblocked for now, let's not pin the rust toolchain version in CI scripts. |
Contributor
Author
|
Oh I missed that PR. In general I think it's better to pin to a working compiler. In the macro that #708 changed, we really meant that it needs to be a type, not a token tree. Once the upstream compiler is fixed, we probably will forget to revert that PR. Also note that if a stable compiler is ever produced with this bug, other CI tests that use it, will start failing too (e.g., the |
This comment was marked as outdated.
This comment was marked as outdated.
Taowyoo
previously approved these changes
Mar 11, 2025
raoulstrackx
force-pushed
the
raoul/rte-381-pin_rust_compiler_for_ci
branch
from
b4f09a8 to
8f184be
Compare
Taowyoo
approved these changes
Mar 11, 2025
Contributor
Author
|
Filed issue #138975 upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling
async-usercallstriggers an upstream compiler bug innightly-2025-02-23or subsequent compilers. This PR pins some CI tests to thenightly-2025-02-22compiler until the bug is resolved upstream. A minimal PoC still needs to be created and a bug report still needs to be filed.