Improve VSS parsing: robust, language-agnostic handling and safe cleanup #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anadrianmanrique
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the way
secretsdump.pyparses the output ofvssadminwhen retrieving shadow copies.Previously, the code relied on English-specific keywords (e.g. "Shadow Copy ID:", "Volume:"), which caused failures on systems where
vssadminoutput is localized (e.g. French, German, Spanish).This patch introduces a regex-based parsing mechanism that:
Extracts the GLOBALROOT path directly,
Searches for nearby GUIDs ({xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx}),
Detects volume letters ((C:), (D:), …) independently of the language,
Adds fallbacks if parsing fails,
Improves error handling when deleting shadows.
This makes secretsdump more robust across non-English domain controllers.
Before :
After :