Add argcomplete functionality #2052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianVollmer
force-pushed
the
add-argcomplete
branch
from
616a425 to
09cc03f
Compare
|
@AdrianVollmer great suggestion! we will review this after the coming 0.13 release. As we pushed back #1810 for 0.14 , these kind of dependencies will be linked only with the examples package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you ever considered adding argcomplete to impacket? Considering that some scripts offer a vast number of options, it could significantly improve the user's quality of life.
Here is an example using the fish shell:
Feel free to just close this if you do not want to add this dependency.